[Fix] : Broadcasting in division and power operations with tests#25
Merged
PrimedErwin merged 3 commits intopocketpy:testfrom Jul 8, 2025
Merged
[Fix] : Broadcasting in division and power operations with tests#25PrimedErwin merged 3 commits intopocketpy:testfrom
PrimedErwin merged 3 commits intopocketpy:testfrom
Conversation
- Refactored GradFn_div and GradFn_pow to handle broadcasting correctly with modulo indexing - Preserved original tensors in Tensor_div and Tensor_pow before broadcasting - Fixed gradient computation in both operations to work with tensors of different shapes - Simplified gradient function implementation by reusing result tensor - Fixed power operation's gradient calculation to use cached result instead of recalculating
Advaitgaur004
changed the title
Advaitgaur004
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed the broadcasting implementation in the division and power operations, similar to our previous fix for the multiplication operation. I've also added backwards tests for both operations to ensure they're working correctly.